WIP: don't simply toss extensions #347
Draft
+161
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely not ready - just dropping this here as a step forward when I pick this up again.
TODO: it doesn't seem fully wise to simply erase the contents of an extension - maybe we should mark that we redacted it, for the future. There's a Meta.security way of doing that (which we normally strip out of resources) or... throw a valueString of "cumulus wuz here" in there... needs a think.
Fixes #346
Checklist
docs/
) needs to be updated